WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248096
Store replaced element aspect ratio dimensions in its own data structure
https://bugs.webkit.org/show_bug.cgi?id=248096
Summary
Store replaced element aspect ratio dimensions in its own data structure
Sammy Gill
Reported
2022-11-18 11:58:42 PST
Replaced elements are currently computing their aspect ratio fairly deep into the call stack and then propagating the computed double back up. This has been introducing some slight precision issues when working with replaced elements and their aspect ratio. Instead the dimensions associated with the ratio should be stored in their own struct and then propagated back up the computeIntrinsicRatioInformation stack. The caller can then decide how they want to use the ratio (compute into a double or use individual dimensions).
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-11-18 11:59:22 PST
<
rdar://problem/102525236
>
Sammy Gill
Comment 2
2022-11-18 12:31:27 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6645
EWS
Comment 3
2022-12-06 13:00:29 PST
Committed
257430@main
(90b0d80278b2): <
https://commits.webkit.org/257430@main
> Reviewed commits have been landed. Closing PR #6645 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug