Bug 248096 - Store replaced element aspect ratio dimensions in its own data structure
Summary: Store replaced element aspect ratio dimensions in its own data structure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-18 11:58 PST by Sammy Gill
Modified: 2022-12-06 13:00 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2022-11-18 11:58:42 PST
Replaced elements are currently computing their aspect ratio fairly deep into the call stack and then propagating the computed double back up. This has been introducing some slight precision issues when working with replaced elements and their aspect ratio. Instead the dimensions associated with the ratio should be stored in their own struct and then propagated back up the computeIntrinsicRatioInformation stack. The caller can then decide how they want to use the ratio (compute into a double or use individual dimensions).
Comment 1 Radar WebKit Bug Importer 2022-11-18 11:59:22 PST
<rdar://problem/102525236>
Comment 2 Sammy Gill 2022-11-18 12:31:27 PST
Pull request: https://github.com/WebKit/WebKit/pull/6645
Comment 3 EWS 2022-12-06 13:00:29 PST
Committed 257430@main (90b0d80278b2): <https://commits.webkit.org/257430@main>

Reviewed commits have been landed. Closing PR #6645 and removing active labels.