WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248088
FRAME and FRAMESET should always be in-flow (and non-floating)
https://bugs.webkit.org/show_bug.cgi?id=248088
Summary
FRAME and FRAMESET should always be in-flow (and non-floating)
Ahmad Saleem
Reported
2022-11-18 10:10:36 PST
Hi Team, While looking at Chrome / Blink "styleadjusder", I noticed the following commit, which fixes some crash fixes stemming from confusing rendering engine: Blink Commit -
https://chromium.googlesource.com/chromium/src.git/+/f47b628e85e5195efc1f152c2bc7a19d20c85fa0
Webkit GitHub -
https://github.com/WebKit/WebKit/blob/main/Source/WebCore/style/StyleAdjuster.cpp#LL290
Just trying to raise this bug so I can do another merge to make Webkit more reliable. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-11-18 10:11:02 PST
(In reply to Ahmad Saleem from
comment #0
)
> Hi Team, > > While looking at Chrome / Blink "styleadjusder", I noticed the following > commit, which fixes some crash fixes stemming from confusing rendering > engine: > > Blink Commit - >
https://chromium.googlesource.com/chromium/src.git/+/
> f47b628e85e5195efc1f152c2bc7a19d20c85fa0 > > Webkit GitHub - >
https://github.com/WebKit/WebKit/blob/main/Source/WebCore/style/
> StyleAdjuster.cpp#LL290 > > Just trying to raise this bug so I can do another merge to make Webkit more > reliable. > > Thanks!
*StyleAdjuster.cpp
Radar WebKit Bug Importer
Comment 2
2022-11-25 10:11:15 PST
<
rdar://problem/102670652
>
Ahmad Saleem
Comment 3
2024-10-13 11:08:46 PDT
Mozilla Firefox has it as well -
https://searchfox.org/mozilla-central/rev/a59018f9ff34170810b43e12bf6f09a1512de7ab/layout/style/res/html.css#652
frameset { display: block ! important; overflow: clip; position: static ! important; float: none ! important; border: none ! important; }
Ahmad Saleem
Comment 4
2025-03-22 23:16:10 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/42901
EWS
Comment 5
2025-06-14 19:41:20 PDT
Committed
296236@main
(c3c083fd5897): <
https://commits.webkit.org/296236@main
> Reviewed commits have been landed. Closing PR #42901 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug