Bug 248015 - [LFC][IFC] Introduce a fast path for finding breaking position when text content uses fixed pitch font
Summary: [LFC][IFC] Introduce a fast path for finding breaking position when text cont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 247782
  Show dependency tree / graph
 
Reported: 2022-11-16 19:45 PST by zalan
Modified: 2022-12-08 13:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2022-11-16 19:56 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.28 KB, patch)
2022-11-17 08:24 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2022-11-17 08:44 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq] Patch (4.31 KB, patch)
2022-12-08 09:11 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-11-16 19:45:59 PST 
see webkit.org/b/221581
Comment 1 zalan 2022-11-16 19:56:22 PST 
Created attachment 463569 [details]
Patch
Comment 2 zalan 2022-11-16 21:22:31 PST 
need to look into imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html
Comment 3 zalan 2022-11-17 08:24:44 PST 
Created attachment 463582 [details]
Patch
Comment 4 zalan 2022-11-17 08:44:21 PST 
Created attachment 463583 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2022-11-23 19:46:16 PST 
<rdar://problem/102637833>
Comment 6 Simon Fraser (smfr) 2022-11-28 11:13:33 PST 
Comment on attachment 463583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463583&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:246
> +                size_t estimatedCharacterCount = availableWidth / monospaceCharacterWidth;

An explicit floor() would make this slightly more self-explanatory
Comment 7 zalan 2022-12-08 09:11:50 PST 
Created attachment 463940 [details]
[fast-cq] Patch
Comment 8 EWS 2022-12-08 13:15:49 PST 
Committed 257585@main (97774366800c): <https://commits.webkit.org/257585@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463940 [details].