Bug 247952 - [check-webkit-style] Handle divergent branch state on multiple remotes
Summary: [check-webkit-style] Handle divergent branch state on multiple remotes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-15 10:56 PST by Jonathan Bedard
Modified: 2022-11-16 09:33 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-11-15 10:56:55 PST 
check-webkit-style attempts to diff against the remote versions of the current branch. This is challenging because it's possible for different remotes to have different versions of the same branch, usually because one remote has a more up to date version than another. We should leverage the branch point and repository.branches_for to only include branch references from remotes which contain the branch point.
Comment 1 Radar WebKit Bug Importer 2022-11-15 10:58:35 PST 
<rdar://problem/102376829>
Comment 2 Jonathan Bedard 2022-11-15 11:00:36 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6521
Comment 3 EWS 2022-11-15 14:10:24 PST 
Committed 256710@main (10e8d00cbce3): <https://commits.webkit.org/256710@main>

Reviewed commits have been landed. Closing PR #6521 and removing active labels.
Comment 4 EWS 2022-11-16 09:33:48 PST 
Committed 252432.831@safari-7614-branch (95d5bbb634bd): <https://commits.webkit.org/252432.831@safari-7614-branch>

Reviewed commits have been landed. Closing PR #205 and removing active labels.