Bug 247944 - Build a SHARED WebCore on WinCairo
Summary: Build a SHARED WebCore on WinCairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-15 07:02 PST by Don Olmstead
Modified: 2022-12-08 21:30 PST (History)
1 user (show)

See Also:

Attachments
[fast-cq] Patch (1.59 KB, patch)
2022-12-08 21:27 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-11-15 07:02:36 PST 
...
Comment 1 Don Olmstead 2022-11-15 07:21:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6519
Comment 2 EWS 2022-12-08 20:44:35 PST 
Committed 257608@main (e912e7b00570): <https://commits.webkit.org/257608@main>

Reviewed commits have been landed. Closing PR #6519 and removing active labels.
Comment 3 Fujii Hironori 2022-12-08 21:22:35 PST 
building WinCairo Debug failed on my PC:

   Creating library lib64\WebKit.lib and object lib64\WebKit.exp
WebView.cpp.obj : error LNK2019: unresolved external symbol "public: __cdecl WebCore::GDIObjectCounter::GDIObjectCounter(char const *)" (??0GDIObjectCounter@WebCore@@QEAA@PEBD@Z) referenced in function "public: void __cdecl WebView::paint(struct HDC__ *,__int64)" (?paint@WebView@@QEAAXPEAUHDC__@@_J@Z)
WebView.cpp.obj : error LNK2019: unresolved external symbol "public: __cdecl WebCore::GDIObjectCounter::~GDIObjectCounter(void)" (??1GDIObjectCounter@WebCore@@QEAA@XZ) referenced in function "public: void __cdecl WebView::paint(struct HDC__ *,__int64)" (?paint@WebView@@QEAAXPEAUHDC__@@_J@Z)

   Creating library lib64\WebKit2.lib and object lib64\WebKit2.exp
UnifiedSource-88d1702b-2.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) class WTF::String __cdecl WebCore::logLevelString(void)" (__imp_?logLevelString@WebCore@@YA?AVString@WTF@@XZ) referenced in function "class WTF::String __cdecl WebKit::UIProcess::webCoreLogLevelString(void)" (?webCoreLogLevelString@UIProcess@WebKit@@YA?AVString@WTF@@XZ)
Comment 4 Fujii Hironori 2022-12-08 21:26:59 PST 
Reopening to attach new patch.
Comment 5 Fujii Hironori 2022-12-08 21:27:15 PST 
Created attachment 463955 [details]
[fast-cq] Patch
Comment 6 EWS 2022-12-08 21:30:52 PST 
Committed 257609@main (850d69c21dc6): <https://commits.webkit.org/257609@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463955 [details].