WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247918
Change ReplaceSelectionCommand::moveNodeOutOfAncestor() to avoid hitting assertion while trying replace selection
https://bugs.webkit.org/show_bug.cgi?id=247918
Summary
Change ReplaceSelectionCommand::moveNodeOutOfAncestor() to avoid hitting asse...
Ahmad Saleem
Reported
2022-11-14 14:36:30 PST
Hi Team, While going through Blink Commits, I came across crash fix in HTML Editing, which can also fix few assertion bugs in Webkit: Blink Commit -
https://src.chromium.org/viewvc/blink?revision=153031&view=revision
Webkit GitHub Source -
https://github.com/WebKit/WebKit/blob/b308d25de831f4b7d9c1d643fd166417ef4a5c5e/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L837
Add: if (!protectedAncestor->parentNode()->hasEditableStyle()) Just wanted to raise to fix it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2022-11-14 19:51:17 PST
Committed
256682@main
(531d3679e268): <
https://commits.webkit.org/256682@main
> Reviewed commits have been landed. Closing PR #6489 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2022-11-14 19:52:18 PST
<
rdar://problem/102349687
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug