Bug 247911 - Progress HTMLDocumentParser state on non-interrupted cases
Summary: Progress HTMLDocumentParser state on non-interrupted cases
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-14 11:50 PST by Ahmad Saleem
Modified: 2023-01-10 09:36 PST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-14 11:50:44 PST
Hi Team,

While going through Blink commit, I came across following:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=181346

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/e7be2359033b5a89111f70b799953e17421eeede/Source/WebCore/html/parser/HTMLDocumentParser.cpp#L446

Need to add:

DocumentParser::stopParsing();

___

It is still present to this date in Blink code:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/parser/html_document_parser.cc;l=992?q=Informs%20the%20rest%20of%20WebCore%20that%20parsing%20is%20really%20finished

Just want to raise it as potential merge due to commit message indicating that it changes "StoppingState" to "StoppedState" when parsing finished with any interruption.

___

Will tag few to comments and since it does not have any test case, I cannot confirm whether it regress any behavior or not

Thanks!
Comment 1 Ahmad Saleem 2022-11-20 17:12:44 PST
This change leads to massive failures across current test and have 70+ test crash on Webkit GTK and leading them out of memory. So it might be not as simple as it is and might need to have more thought given before hand.

I would let others to comment whether we should keep this open or we should close this with "RESOLVED LATER" or "RESOLVED WONTFIX". Thanks!
Comment 2 Radar WebKit Bug Importer 2022-11-21 11:51:15 PST
<rdar://problem/102586999>