Bug 247907 - Add signposts and profiling support to JetStream2
Summary: Add signposts and profiling support to JetStream2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-14 10:55 PST by hysu
Modified: 2022-12-09 12:30 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2022-11-14 10:55:00 PST 
By default, trying to profile JetStream may sometimes result in the profile being cut off before the test finishes due to file size issues. Support for subtests needs to be added in the run-benchmarks harness, and profiling support should require a subtest to be specified (to avoid the test cutting off). 

Also, JetStream should support signposting to help label generated profiles.
Comment 1 Radar WebKit Bug Importer 2022-11-14 10:55:20 PST 
<rdar://problem/102328951>
Comment 2 hysu 2022-12-06 11:44:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7216
Comment 3 hysu 2022-12-06 16:48:40 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7232
Comment 4 EWS 2022-12-09 12:30:19 PST 
Committed 257642@main (c6a3a8988a7f): <https://commits.webkit.org/257642@main>

Reviewed commits have been landed. Closing PR #7232 and removing active labels.