NEW247905
Ignore whitespace style check on Windows 
https://bugs.webkit.org/show_bug.cgi?id=247905
Summary Ignore whitespace style check on Windows
Don Olmstead
Reported 2022-11-14 10:08:05 PST
When using `git-webkit pr` on Windows I have style checker errors due to line ending. These line ending errors don't matter when pushed to GitHub and the EWS style checker always passes. ``` ERROR: Source/WebCore/CMakeLists.txt:2041: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:59: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:74: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. .... ``` Is there any way to suppress them so my PR will automatically be uploaded? I have to make sure I respond `yes` to the PR every iteration.
Attachments
Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-11-14 12:14:47 PST
Some layout tests fail if they are CR-LF line end style. I think we should change git config. git config --global core.autocrlf false choco install -y git.install --params /NoAutoCrlf
Radar WebKit Bug Importer
Comment 2 2022-11-21 10:09:16 PST
<rdar://problem/102585446>
Note You need to log in before you can comment on or make changes to this bug.