Bug 247905 - Ignore whitespace style check on Windows
Summary: Ignore whitespace style check on Windows
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-14 10:08 PST by Don Olmstead
Modified: 2022-11-21 10:09 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-11-14 10:08:05 PST
When using `git-webkit pr` on Windows I have style checker errors due to line ending. These line ending errors don't matter when pushed to GitHub and the EWS style checker always passes.

```
ERROR: Source/WebCore/CMakeLists.txt:2041:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:59:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:74:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
....
```

Is there any way to suppress them so my PR will automatically be uploaded? I have to make sure I respond `yes` to the PR every iteration.
Comment 1 Fujii Hironori 2022-11-14 12:14:47 PST
Some layout tests fail if they are CR-LF line end style.
I think we should change git config.

git config --global core.autocrlf false
choco install -y git.install --params /NoAutoCrlf
Comment 2 Radar WebKit Bug Importer 2022-11-21 10:09:16 PST
<rdar://problem/102585446>