Bug 247879 - Clean up handling of background-position shorthand in StyleProperties::asTextInternal()
Summary: Clean up handling of background-position shorthand in StyleProperties::asText...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-13 23:10 PST by Tim Nguyen (:ntim)
Modified: 2022-11-14 04:06 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-11-13 23:10:51 PST 
The old code was collapsing background-position-x/y into background-position.
It is not needed anymore, as returning true in canUseShorthandForLonghand for background-position has the same effect.

Test: fast/css/background-position-serialize.html
Comment 1 Radar WebKit Bug Importer 2022-11-13 23:11:51 PST 
<rdar://problem/102306296>
Comment 2 Tim Nguyen (:ntim) 2022-11-13 23:13:48 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6458
Comment 3 EWS 2022-11-14 01:37:13 PST 
Committed 256643@main (fd7fe182b10d): <https://commits.webkit.org/256643@main>

Reviewed commits have been landed. Closing PR #6458 and removing active labels.