Bug 247834 - Fix comparison between two vectors with different inline capacity
Summary: Fix comparison between two vectors with different inline capacity
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-11 18:00 PST by Ahmad Saleem
Modified: 2022-11-11 19:02 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-11 18:00:41 PST 
Hi Team,

While going through Blink commits, I came across another potential Blink Commit, where Webkit is still using old one.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/378ddcc6e178ab7ab43e01f55abfeb2f164bd0ff

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/125577b7ea29fabfde65c24ef617fa9a684acc3b/Source/WTF/wtf/Vector.h#LL229

I just wanted to post this for others to comment whether it is something needed in Webkit or not.

Thanks!
Comment 1 Alexey Proskuryakov 2022-11-11 19:02:47 PST 
Our code is different, we don't take the shortcut based on pointer being null. I don't think that we ever had this error, must have been introduced by Blink after forking.