WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
247834
Fix comparison between two vectors with different inline capacity
https://bugs.webkit.org/show_bug.cgi?id=247834
Summary
Fix comparison between two vectors with different inline capacity
Ahmad Saleem
Reported
2022-11-11 18:00:41 PST
Hi Team, While going through Blink commits, I came across another potential Blink Commit, where Webkit is still using old one. Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/378ddcc6e178ab7ab43e01f55abfeb2f164bd0ff
Webkit GitHub Source -
https://github.com/WebKit/WebKit/blob/125577b7ea29fabfde65c24ef617fa9a684acc3b/Source/WTF/wtf/Vector.h#LL229
I just wanted to post this for others to comment whether it is something needed in Webkit or not. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2022-11-11 19:02:47 PST
Our code is different, we don't take the shortcut based on pointer being null. I don't think that we ever had this error, must have been introduced by Blink after forking.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug