Bug 247753 - Update PGO scripts to refer to run-benchmarks' renamed --generate-pgo-profiles flag
Summary: Update PGO scripts to refer to run-benchmarks' renamed --generate-pgo-profile...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-10 11:05 PST by hysu
Modified: 2022-11-11 12:02 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2022-11-10 11:05:34 PST 
https://bugs.webkit.org/show_bug.cgi?id=247496 introduced profiling into run-benchmarks, so we've had to rename --generate-profiles to --generate-pgo-profiles to avoid confusion.

Various PGO scripts that run on-desk and in automation refer to this flag, and should be updated. Ideally, we'd like to remove the --generate-profiles flag and only leave --generate-pgo-profiles.
Comment 1 Radar WebKit Bug Importer 2022-11-10 11:11:18 PST 
<rdar://problem/102202608>
Comment 2 hysu 2022-11-10 14:15:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6364
Comment 3 EWS 2022-11-11 12:02:48 PST 
Committed 256583@main (bb52774d658f): <https://commits.webkit.org/256583@main>

Reviewed commits have been landed. Closing PR #6364 and removing active labels.