Bug 247736 - [WebAudio][GStreamer] Use single non-interleaved appsrc instead of multi appsrcs with audiointerleave
Summary: [WebAudio][GStreamer] Use single non-interleaved appsrc instead of multi apps...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-10 08:27 PST by Bastian Krause
Modified: 2022-11-14 04:35 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bastian Krause 2022-11-10 08:27:35 PST 
GStreamer 1.16 brought support for planar (non-interleaved) raw audio. Let's use that to simplify the "1 appsrc per channel + audiointerleave" approach to a single appsrc with non-interleaved layout.

We do not need to keep the appsrcs and mapped buffers per channel around which lets us drop a bunch of code.

This approach cuts the overhead the GStreamer pipeline causes on the WPEWebProcess in half on an NXP i.MX 6 DualLite.
Comment 1 Bastian Krause 2022-11-10 08:29:49 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6350
Comment 2 EWS 2022-11-14 04:34:29 PST 
Committed 256648@main (63076adef16d): <https://commits.webkit.org/256648@main>

Reviewed commits have been landed. Closing PR #6350 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-11-14 04:35:23 PST 
<rdar://problem/102315904>