Bug 247704 - [AVIF Downlevels] Animated AVIF image animates only one loop
Summary: [AVIF Downlevels] Animated AVIF image animates only one loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-09 15:49 PST by Said Abou-Hallawa
Modified: 2022-12-07 13:58 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-11-09 15:49:34 PST 
This bug happens because of the hand crafted implementation of AVIFImageReader::repetitionCount(). This was added in r275184.

1. According to https://github.com/AOMediaCodec/av1-avif/issues/73#issuecomment-803017653, libavif does not provide the repetition count.
2. macOS system frameworks do not provide the repetition count for animated AVIF.
3. Chromium just indefinitely repeats all animated AVIF frames.

So to be compatible with other browsers and image viewers, I think we need to return RepetitionCountInfinite for all animated AVIF images.
Comment 1 Radar WebKit Bug Importer 2022-11-09 15:51:55 PST 
<rdar://problem/102164553>
Comment 2 Said Abou-Hallawa 2022-11-09 17:35:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6329
Comment 3 EWS 2022-11-14 12:01:54 PST 
Committed 256665@main (70ff964ee191): <https://commits.webkit.org/256665@main>

Reviewed commits have been landed. Closing PR #6329 and removing active labels.