Bug 247698 - Simplify paint rect calculations in RenderReplaced::shouldPaint
Summary: Simplify paint rect calculations in RenderReplaced::shouldPaint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-09 14:14 PST by Ahmad Saleem
Modified: 2022-11-09 19:52 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-09 14:14:01 PST 
Hi Team,

I was going through Chromium / Blink commit history and found this simplification and we are still having old code:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=198240&view=revision

It does not have any test case but it is just optimizing code via refactoring.

Webkit GitHub - https://github.com/WebKit/WebKit/blob/097123389da2454304dbbd9e85129eae13ea307c/Source/WebCore/rendering/RenderReplaced.cpp#L324

This is just a bug to merge the change, which will refactor and optimize this codepath.

Thanks!
Comment 1 EWS 2022-11-09 19:51:18 PST 
Committed 256521@main (d30c0aeee94b): <https://commits.webkit.org/256521@main>

Reviewed commits have been landed. Closing PR #6318 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-11-09 19:52:20 PST 
<rdar://problem/102173487>