Bug 247693 - Enable first party for cookies check on Linux
Summary: Enable first party for cookies check on Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: InRadar
Depends on: 248033
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-09 12:31 PST by Alex Christensen
Modified: 2022-12-21 04:12 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-11-09 12:31:41 PST 
I think 256488@main may have fixed the problem.
Comment 1 Radar WebKit Bug Importer 2022-11-09 12:31:57 PST 
<rdar://problem/102154645>
Comment 2 Alex Christensen 2022-11-09 12:33:18 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6314
Comment 3 Fujii Hironori 2022-11-10 12:34:45 PST 
gtk-wk2 EWS reported: <https://ews-build.webkit.org/#/builders/35/builds/30987>

> Found 15 new test failures:
> http/tests/contentextensions/video-element-resource-type.html,
> http/tests/media/video-auth-with-allowCrossOriginSubresourcesToAskForCredentials.html,
> http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html,
> http/tests/security/canvas-remote-read-remote-video-hls.html,
> http/tests/security/canvas-remote-read-remote-video-localhost.html,
> http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html,
> http/tests/security/local-video-source-from-remote.html,
> http/tests/security/video-cross-origin-accessfailure.html,
> http/tests/security/video-cross-origin-caching.html,
> http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html
> ...


They have video/audio elements using cross origin resources.
They should have correct firstPartyForCookies.

request.setFirstPartyForCookies is called here.
https://github.com/WebKit/WebKit/blob/d30c0aeee94bcc5f57bfe808c4d379fe6fb575a4/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp#L651
Comment 4 Carlos Garcia Campos 2022-12-10 06:57:56 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7438
Comment 5 EWS 2022-12-21 04:11:57 PST 
Committed 258186@main (59d042a7a674): <https://commits.webkit.org/258186@main>

Reviewed commits have been landed. Closing PR #6314 and removing active labels.