Bug 247646 - onorientationchange and orientation attributes must be present unconditionally even on platforms without orientation change
Summary: onorientationchange and orientation attributes must be present unconditionall...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 253435
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-08 14:42 PST by Darin Adler
Modified: 2023-03-06 07:43 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-11-08 14:42:26 PST 
https://compat.spec.whatwg.org/#windoworientation-interface

Our implementation is only on platforms with an orientation concept, but the specification says it should be everywhere. That is straightforward to do.
Comment 1 Radar WebKit Bug Importer 2022-11-08 14:44:18 PST 
<rdar://problem/102110117>
Comment 2 Darin Adler 2022-11-08 14:55:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6269
Comment 3 EWS 2022-11-08 17:00:33 PST 
Committed 256469@main (052d5b6a2ca0): <https://commits.webkit.org/256469@main>

Reviewed commits have been landed. Closing PR #6269 and removing active labels.
Comment 4 Chris Dumez 2023-03-06 07:31:37 PST 
The spec (https://compat.spec.whatwg.org/#windoworientation-interface) says:
"User agents implementing the window.orientation attribute and its associated orientationchange event must not expose them on non-Mobile platforms."

Firefox and Chrome both don't expose this on Desktop. We have evidence of site breakage from this (rdar://106273441). I think we should revert.