WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247544
Building WebKit and running MiniBrowser is non-trivial
https://bugs.webkit.org/show_bug.cgi?id=247544
Summary
Building WebKit and running MiniBrowser is non-trivial
Saagar Jha
Reported
2022-11-06 03:46:34 PST
WebKit has historically made running MiniBrowser from Xcode with a freshly built WebKit a one-click process. This worked because the "All Source" scheme had the MiniBrowser app set as its executable, so you could just hit ⌘R and it would launch it for you.
https://bugs.webkit.org/show_bug.cgi?id=239301
broke this, justifying the change by mentioning that "All Tools" contains MiniBrowser. However, that scheme was never updated to point at the MiniBrowser executable. To make matters worse, in a future change (
https://bugs.webkit.org/show_bug.cgi?id=243806
) the WebKit build was pulled out of "All Tools" entirely. Furthermore, the "MiniBrowser" scheme mentioned as the intended way to build the stack through WebKit does not do anything but build the app, because it does not depend on anything. (In fact if you try using it the build just fails.) To avoid confusion, WebKit should bring back the one-click flow for running MiniBrowser. It would be nice if this could be made obvious via documentation or better naming too, but let's start with something small first :)
Attachments
Add attachment
proposed patch, testcase, etc.
Saagar Jha
Comment 1
2022-11-06 05:37:54 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6185
EWS
Comment 2
2022-11-08 15:42:40 PST
Committed
256466@main
(40f091d7f369): <
https://commits.webkit.org/256466@main
> Reviewed commits have been landed. Closing PR #6185 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-11-08 15:43:23 PST
<
rdar://problem/102112998
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug