Bug 247505 - [MobileMiniBrowser] Add a close button to the Settings modal.
Summary: [MobileMiniBrowser] Add a close button to the Settings modal.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-04 15:39 PDT by Ryan Reno
Modified: 2022-11-04 15:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reno 2022-11-04 15:39:55 PDT 
The settings modal in MobileMiniBrowser can be closed by dragging down but that's not necessarily obvious. Add a close button to provide a more intuitive way to cancel any settings changes.
Comment 1 Radar WebKit Bug Importer 2022-11-04 15:40:11 PDT 
<rdar://problem/101978776>
Comment 2 Ryan Reno 2022-11-04 15:41:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/6151
Comment 3 EWS 2022-11-04 15:54:01 PDT 
Committed 256343@main (6af97a937a5c): <https://commits.webkit.org/256343@main>

Reviewed commits have been landed. Closing PR #6151 and removing active labels.