Bug 247411 - Changes to the filter property are sometimes ignored
Summary: Changes to the filter property are sometimes ignored
Status: RESOLVED DUPLICATE of bug 243808
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-02 23:52 PDT by Cameron McCormack (:heycam)
Modified: 2022-11-03 17:06 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-11-02 23:52:10 PDT
In SVGResourceCache::clientStyleChanged we return early if diff == StyleDifference::Equal.  But we can have StyleDifference::Equal even when the filter property has changed: specifically, when the element does not have a layer, RenderElement::adjustStyleDifference declines to set any new diff value.

The result of this is that changes to the filter property are sometimes not acted upon.

We can fix this by removing the early exit or by introducing a new StyleDifference value to use when the filter property changes and there is no layer.
Comment 1 Cameron McCormack (:heycam) 2022-11-02 23:52:52 PDT
rdar://97335496
Comment 2 Cameron McCormack (:heycam) 2022-11-03 17:06:29 PDT

*** This bug has been marked as a duplicate of bug 243808 ***