<rdar://problem/101889227>

Created attachment 463374 [details]
Patch

Comment on attachment 463374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463374&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1893
> +    updateIsolatedTree(*object, AXNotification::AXActiveDescendantChanged);

If document().focusedElement() == element, we will do this below:

postNotification(target, &document(), AXActiveDescendantChanged);

Causing a duplicated isolated tree update. Should we try to avoid this duplicate update somehow?

> Source/WebCore/accessibility/AXObjectCache.cpp:1896
> +    // NOtify active descendant changes only for the focused element.

Typo here, capital O in "NOtify"

Created attachment 463388 [details]
Patch

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 463374 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463374&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:1893
> > +    updateIsolatedTree(*object, AXNotification::AXActiveDescendantChanged);
> 
> If document().focusedElement() == element, we will do this below:
> 
> postNotification(target, &document(), AXActiveDescendantChanged);
> 
> Causing a duplicated isolated tree update. Should we try to avoid this
> duplicate update somehow?

Yes, we should actually call postPlatformNotification instead. This made apparent the need to also update the target element when it is different from the original element.

> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:1896
> > +    // NOtify active descendant changes only for the focused element.
> 
> Typo here, capital O in "NOtify"

Fixed in latest patch.

Created attachment 463389 [details]
Patch

Committed 256279@main (3b4b837022dc): <https://commits.webkit.org/256279@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463389 [details].