Bug 247360 - Constructing shared CARingBuffer cannot fail
Summary: Constructing shared CARingBuffer cannot fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-02 05:30 PDT by Kimmo Kinnunen
Modified: 2022-11-03 08:23 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-11-02 05:30:20 PDT 
Constructing shared CARingBuffer cannot fail

This is a problem because shared CARingBuffers are used cross-process, and the WP might send data that would construct a potentially invalid CARingBuffer.
This leads to code that uses empty instances instead of not checking all use-sites correctly. This in turn leads to running code that is expected to only run when the ring buffer is correct.
Comment 1 Radar WebKit Bug Importer 2022-11-02 05:30:40 PDT 
<rdar://problem/101856691>
Comment 2 Kimmo Kinnunen 2022-11-02 05:56:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/6032
Comment 3 EWS 2022-11-03 08:23:29 PDT 
Committed 256273@main (eece78fdf9b2): <https://commits.webkit.org/256273@main>

Reviewed commits have been landed. Closing PR #6032 and removing active labels.