Bug 247342 - [git-webkit] Print help when multiple unknown arguments are provided
Summary: [git-webkit] Print help when multiple unknown arguments are provided
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-01 16:21 PDT by Jonathan Bedard
Modified: 2022-11-16 09:15 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-11-01 16:21:02 PDT
In some commands, git-webkit forwards unknown arguments on to git itself. This means that argparse doesn't always recognize that a command is invalid because it will, in some cases, just return unknown arguments to be forwarded. Notably, this is the case for `git-webkit -pr --rebase`. If the user's arguments don't result in a program definition, we should print the help message and exit the program.
Comment 1 Radar WebKit Bug Importer 2022-11-01 16:22:43 PDT
<rdar://problem/101830556>
Comment 2 Jonathan Bedard 2022-11-01 16:24:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/6014
Comment 3 EWS 2022-11-09 18:05:45 PST
Committed 256516@main (68e00a092301): <https://commits.webkit.org/256516@main>

Reviewed commits have been landed. Closing PR #6014 and removing active labels.
Comment 4 EWS 2022-11-16 09:15:08 PST
Committed 252432.829@safari-7614-branch (7cf9c2004005): <https://commits.webkit.org/252432.829@safari-7614-branch>

Reviewed commits have been landed. Closing PR #207 and removing active labels.