Bug 247332 - Checking m_defaultPageGroup->preferences() in WebProcessPool::platformInitializeWebProcess() is probably wrong
Summary: Checking m_defaultPageGroup->preferences() in WebProcessPool::platformInitial...
Status: RESOLVED DUPLICATE of bug 257750
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-01 13:13 PDT by Simon Fraser (smfr)
Modified: 2023-06-06 13:22 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-11-01 13:13:45 PDT 
WebProcessPool::platformInitializeWebProcess() does:

    if (m_defaultPageGroup->preferences().useGPUProcessForDOMRenderingEnabled())
        parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();

but m_defaultPageGroup->preferences() is uninitialized at this point, so this condition is never hit.

The same applies to checks for mediaDevicesEnabled and captureAudioInGPUProcessEnabled lower down.

Behavior might be different in different UI apps (depending on their use of the API). I reproduced the issue in MiniBrowser on macOS.
Comment 1 Radar WebKit Bug Importer 2022-11-01 13:14:17 PDT 
<rdar://problem/101821075>
Comment 2 Simon Fraser (smfr) 2022-11-01 13:56:23 PDT Comment hidden (obsolete)
Comment 3 Simon Fraser (smfr) 2022-11-01 14:13:12 PDT 
The config in MobileSafari is such that these checks succeed.
Comment 4 Per Arne Vollan 2023-06-06 13:22:04 PDT 

*** This bug has been marked as a duplicate of bug 257750 ***