Bug 247275 - web manifest: implement orientation member parsing
Summary: web manifest: implement orientation member parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcos Caceres
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-31 11:48 PDT by Marcos Caceres
Modified: 2023-03-28 15:45 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Caceres 2022-10-31 11:48:11 PDT 
The manifest's orientation member is a string that serves as the default screen orientation for all top-level browsing contexts of the web application. The possible values are those of the OrientationLockType enum, which in this specification are referred to as the orientation values (i.e., "any", "natural", "landscape", "portrait", "portrait-primary", "portrait-secondary", "landscape-primary", or "landscape-secondary").

Spec:
https://www.w3.org/TR/appmanifest/#orientation-member
Comment 1 Radar WebKit Bug Importer 2022-10-31 12:53:50 PDT 
<rdar://problem/101770484>
Comment 2 Marcos Caceres 2022-10-31 13:00:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5971
Comment 3 Marcos Caceres 2023-03-16 20:55:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11636
Comment 4 Marcos Caceres 2023-03-26 17:03:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11986
Comment 5 EWS 2023-03-28 15:45:41 PDT 
Committed 262241@main (f3713b339917): <https://commits.webkit.org/262241@main>

Reviewed commits have been landed. Closing PR #11986 and removing active labels.