Bug 247238 - [IFC][Integration] Disable IFC for RenderVTTCue
Summary: [IFC][Integration] Disable IFC for RenderVTTCue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 247108
  Show dependency tree / graph
 
Reported: 2022-10-29 20:28 PDT by zalan
Modified: 2022-10-30 19:12 PDT (History)
6 users (show)

See Also:

Attachments
[fast-cq]Patch (3.05 KB, patch)
2022-10-29 20:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (1.57 KB, patch)
2022-10-30 12:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-10-29 20:28:43 PDT 
ssia
Comment 1 zalan 2022-10-29 20:32:58 PDT 
Created attachment 463306 [details]
[fast-cq]Patch
Comment 2 Antti Koivisto 2022-10-30 01:24:17 PDT 
Comment on attachment 463306 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463306&action=review

> COMMIT_MESSAGE:6
> +RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css)

mediaControls.css is some old leftover that is not used at least on Apple platforms. But I suppose the modern controls ended up disabling it anyway.
Comment 3 EWS 2022-10-30 07:08:15 PDT 
Committed 256139@main (ec9adcfcd3db): <https://commits.webkit.org/256139@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463306 [details].
Comment 4 Radar WebKit Bug Importer 2022-10-30 07:09:18 PDT 
<rdar://problem/101729043>
Comment 5 zalan 2022-10-30 07:09:50 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 463306 [details]
> [fast-cq]Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463306&action=review
> 
> > COMMIT_MESSAGE:6
> > +RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css)
> 
> mediaControls.css is some old leftover that is not used at least on Apple
> platforms. But I suppose the modern controls ended up disabling it anyway.
oh ok, webinpsector shows line-box-contain
Comment 6 zalan 2022-10-30 12:33:56 PDT 
Reopening to attach new patch.
Comment 7 zalan 2022-10-30 12:34:03 PDT 
Created attachment 463315 [details]
[fast-cq]Patch
Comment 8 EWS 2022-10-30 18:41:48 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html
Comment 9 EWS 2022-10-30 19:12:18 PDT 
Committed 256144@main (81ba4136c619): <https://commits.webkit.org/256144@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463315 [details].