WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
247232
additionalOutlineSize is always zero in ShadowData[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=247232
Summary
additionalOutlineSize is always zero in ShadowData[cpp|h]
Ahmad Saleem
Reported
2022-10-29 13:33:25 PDT
Hi Team, This is bug created for removing the "additionalOutlineSize" because it is always zerp. Commit -
https://src.chromium.org/viewvc/blink?view=revision&revision=180370
It does not have any test case and would make the code cleaner:
https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.h#L90
https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.cpp#L81
https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.cpp#L84
https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.cpp#L84
and other instances. ___ There are no usage of it outside above these two files while checking via Webkit GitHub search. I am creating this bug for the PR purposes but if it serves any other purpose, happy to close it out later. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-10-29 14:09:53 PDT
I tried but it is not easy:
https://github.com/WebKit/WebKit/pull/5938
There is reference here:
https://github.com/WebKit/WebKit/blob/037ca440c5c2b37eb7677af16d6c726cb8163aa4/Source/WebCore/rendering/RenderObject.cpp#L1777
and if you remove without removing reference, you get this build error: ./rendering/RenderObject.cpp:1777:20: error: no matching member function for call to 'adjustRectForShadow'
Radar WebKit Bug Importer
Comment 2
2022-11-05 13:34:17 PDT
<
rdar://problem/102000520
>
Ahmad Saleem
Comment 3
2024-03-06 05:56:06 PST
Not Applicable - post
271254@main
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug