Bug 247172 - Fix default angle cases from at-font-face-descriptors.html
Summary: Fix default angle cases from at-font-face-descriptors.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 246579
  Show dependency tree / graph
 
Reported: 2022-10-27 23:22 PDT by Tim Nguyen (:ntim)
Modified: 2022-10-28 06:47 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-10-27 23:22:52 PDT 
The default angle is now 14deg, not 20deg, but even then, I do not think we should treat the default angle specially in this case, given that it changed. We lose information by serializing to the shorter form (did the author intend to mean 20deg or the current default angle?). For clarity, always putting the angle is better.

See: https://github.com/w3c/csswg-drafts/issues/2295
Comment 1 Radar WebKit Bug Importer 2022-10-27 23:23:20 PDT 
<rdar://problem/101666575>
Comment 2 Tim Nguyen (:ntim) 2022-10-27 23:25:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5890
Comment 3 Tim Nguyen (:ntim) 2022-10-27 23:26:12 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/36707
Comment 4 EWS 2022-10-28 06:47:05 PDT 
Committed 256098@main (3e8ac0a21f30): <https://commits.webkit.org/256098@main>

Reviewed commits have been landed. Closing PR #5890 and removing active labels.