Bug 247140 - Fix how we set fontWeight so that it remains in bounds
Summary: Fix how we set fontWeight so that it remains in bounds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Chirag M Shah
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-27 11:09 PDT by Chirag M Shah
Modified: 2022-11-04 13:48 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chirag M Shah 2022-10-27 11:09:56 PDT 
Currently, fontWeights can 0, which results in a crash due to it not being a valid key for segmentedFontFaceCache (when wrapped inside a FontSelectionRequest). We need to fix that.
Comment 1 Chirag M Shah 2022-10-27 11:13:58 PDT 
https://github.com/WebKit/WebKit/pull/5836
Comment 2 EWS 2022-10-28 17:27:25 PDT 
Committed 256123@main (3070b3d704a3): <https://commits.webkit.org/256123@main>

Reviewed commits have been landed. Closing PR #5836 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-28 17:28:21 PDT 
<rdar://problem/101699349>
Comment 4 Chirag M Shah 2022-11-04 13:46:08 PDT 
Corrected radar: rdar://101705191
Comment 5 Chirag M Shah 2022-11-04 13:47:39 PDT 
<rdar://problem/101699349>
Comment 6 Chirag M Shah 2022-11-04 13:48:52 PDT 
rdar://100986499