Bug 247127 - StyleImages need to know if they are painting a first-line so they can use the firstLineStyle() instead of style()
Summary: StyleImages need to know if they are painting a first-line so they can use th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-27 07:59 PDT by Sam Weinig
Modified: 2023-08-16 22:11 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2022-10-27 07:59:21 PDT 
When fixing https://bugs.webkit.org/show_bug.cgi?id=246927, I ran into an issue do to StyleImages (specifically the StyleGradientImage) not know if they are painting a first-line so they can't figure out to use the firstLineStyle() instead of style(). We should pass that information to them along with the RenderElement.

See https://github.com/WebKit/WebKit/pull/5692#discussion_r1005748227
Comment 1 Radar WebKit Bug Importer 2022-11-03 08:00:19 PDT 
<rdar://problem/101911951>
Comment 2 Antti Koivisto 2023-08-16 01:11:14 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16739
Comment 3 EWS 2023-08-16 22:10:38 PDT 
Committed 266988@main (e993429b13d8): <https://commits.webkit.org/266988@main>

Reviewed commits have been landed. Closing PR #16739 and removing active labels.