Bug 247108 - [LFC][IFC] Add support for "line-box-contain: inline-box"
Summary: [LFC][IFC] Add support for "line-box-contain: inline-box"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 247238
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-26 21:08 PDT by zalan
Modified: 2022-10-30 21:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.85 KB, patch)
2022-10-26 21:14 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (12.06 KB, patch)
2022-10-27 12:07 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.19 KB, patch)
2022-10-29 11:11 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (13.19 KB, patch)
2022-10-30 07:19 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq]Patch (13.19 KB, patch)
2022-10-30 20:07 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-10-26 21:08:37 PDT
ssia
Comment 1 zalan 2022-10-26 21:14:47 PDT
Created attachment 463267 [details]
Patch
Comment 2 Antti Koivisto 2022-10-27 07:02:53 PDT
Comment on attachment 463267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463267&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:56
> -    FlowHasLineBoxContainProperty                = 1LLU  << 16,
> +    // Unused                                    = 1LLU  << 16,

nice!
Comment 3 zalan 2022-10-27 12:07:23 PDT
Created attachment 463281 [details]
Patch
Comment 4 zalan 2022-10-29 11:11:47 PDT
Created attachment 463301 [details]
Patch
Comment 5 zalan 2022-10-30 07:19:39 PDT
Created attachment 463310 [details]
Patch
Comment 6 zalan 2022-10-30 20:07:41 PDT
Created attachment 463317 [details]
[fast-cq]Patch
Comment 7 EWS 2022-10-30 21:30:34 PDT
Committed 256147@main (9d09db431467): <https://commits.webkit.org/256147@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463317 [details].
Comment 8 Radar WebKit Bug Importer 2022-10-30 21:31:19 PDT
<rdar://problem/101741664>