RESOLVED FIXED 247092
[GTK4] GdkEvent should be managed by GRefPtr, not GUniquePtr 
https://bugs.webkit.org/show_bug.cgi?id=247092
Summary [GTK4] GdkEvent should be managed by GRefPtr, not GUniquePtr
Michael Catanzaro
Reported 2022-10-26 15:12:48 PDT
In GTK 3, we use GUniquePtr to manage the lifetime of GdkEvents. But in GTK 4, we should switch to GRefPtr instead, rather than using a GUniquePtr that confusingly "deletes" the GdkEvent with gdk_event_unref().
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2022-10-26 16:31:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5831
Michael Catanzaro
Comment 2 2022-11-09 10:23:45 PST
*** Bug 243290 has been marked as a duplicate of this bug. ***
EWS
Comment 3 2022-11-14 05:45:20 PST
Committed 256651@main (242c638012dd): <https://commits.webkit.org/256651@main> Reviewed commits have been landed. Closing PR #5831 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.