Bug 247024 - [MSVC] Suppress warning C4805: 'operation' : unsafe mix of type 'type' and type 'type' in operation
Summary: [MSVC] Suppress warning C4805: 'operation' : unsafe mix of type 'type' and ty...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-25 13:45 PDT by Fujii Hironori
Modified: 2022-10-25 14:16 PDT (History)
13 users (show)

See Also:

Attachments
[fast-cq] Patch (1.28 KB, patch)
2022-10-25 13:47 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
[fast-cq] Patch (1.65 KB, patch)
2022-10-25 14:06 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-10-25 13:45:29 PDT 
WinCairo EWS is failing to compile due to the following warning.

C:\BW\WinCairo-EWS\build\Source\WebCore\platform\graphics\angle\ANGLEUtilities.cpp(155): error C2220: the following warning is treated as an error
C:\BW\WinCairo-EWS\build\Source\WebCore\platform\graphics\angle\ANGLEUtilities.cpp(155): warning C4805: '==': unsafe mix of type 'GLboolean' and type 'bool' in operation
Comment 1 Fujii Hironori 2022-10-25 13:47:44 PDT 
Created attachment 463242 [details]
[fast-cq] Patch
Comment 2 Fujii Hironori 2022-10-25 13:56:08 PDT 
Other ports don't complain. I think we should suppress warning C4805.
Comment 3 Fujii Hironori 2022-10-25 14:06:51 PDT 
Created attachment 463243 [details]
[fast-cq] Patch
Comment 4 EWS 2022-10-25 14:15:43 PDT 
Committed 255981@main (fbeb80ee96c9): <https://commits.webkit.org/255981@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463243 [details].
Comment 5 Radar WebKit Bug Importer 2022-10-25 14:16:19 PDT 
<rdar://problem/101561022>