Bug 246939 - Use the correct paint methods for painting a section rect of RenderWidgets
Summary: Use the correct paint methods for painting a section rect of RenderWidgets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-24 03:13 PDT by Ahmad Saleem
Modified: 2022-11-01 11:34 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-10-24 03:13:05 PDT 
Hi Team,

I tried to find the related issue for this but couldn't and it was fixed in below commit:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=181068&view=revision

We still have this FIXME, so I thought it would be good to fix this bug in Webkit upstream as well.

Remove this and update comment - https://github.com/WebKit/WebKit/blob/05f04306d2dc59ca6b5c255a6e31483799daf9f8/Source/WebCore/rendering/RenderObject.h#L734

Update this - https://github.com/WebKit/WebKit/blob/fc014916474a9e42b1528fc70ecfdbfdce538c44/Source/WebCore/rendering/RenderElement.h#L147

Remove this "FIXME" - https://github.com/WebKit/WebKit/blob/0efc0bf9f32501aa0d73f867043d0ba1cc417d40/Source/WebCore/rendering/RenderWidget.cpp#L343

Just wanted to create bug before doing PR.

Thanks!
Comment 1 Simon Fraser (smfr) 2022-10-24 08:50:40 PDT 
Does the Blink testcase reproduce a bug in WebKit?
Comment 2 Ahmad Saleem 2022-10-24 09:15:17 PDT 
(In reply to Simon Fraser (smfr) from comment #1)
> Does the Blink testcase reproduce a bug in WebKit?

I tried but I get error for Chrome and Firefox:

JSFiddle - https://jsfiddle.net/65kpcfar/show

Safari 16 show 'grey' square box while Firefox Nightly 108 and Chrome Canary 109 show this error:

Uncaught IndexSizeError: Failed to execute 'setBaseAndExtent' on 'Selection': There is no child at offset 1."

IndexSizeError: Selection.setBaseAndExtent: The focus offset value 1 is out of range"
Comment 3 Radar WebKit Bug Importer 2022-10-31 03:14:17 PDT 
<rdar://problem/101749980>
Comment 4 Simon Fraser (smfr) 2022-10-31 15:48:13 PDT 
https://github.com/WebKit/WebKit/pull/5704
Comment 5 EWS 2022-11-01 11:34:51 PDT 
Committed 256191@main (fe7889ca7da9): <https://commits.webkit.org/256191@main>

Reviewed commits have been landed. Closing PR #5704 and removing active labels.