Bug 246931 - Omit "normal" value for line-height from font shorthand in specified style too, not just computed
Summary: Omit "normal" value for line-height from font shorthand in specified style to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 246579
  Show dependency tree / graph
 
Reported: 2022-10-23 21:20 PDT by Darin Adler
Modified: 2022-10-25 16:52 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-10-23 21:20:10 PDT 
After fixing bug 246600 there is this loose end. We should not serialize " / normal" for line-height even in specified style.
Comment 1 Darin Adler 2022-10-23 21:30:12 PDT 
The tests are unambiguous about this, although the standard is a little bit ambiguous. Either way, this should be straightforward.
Comment 2 Radar WebKit Bug Importer 2022-10-23 23:21:17 PDT 
<rdar://problem/101487839>
Comment 3 Darin Adler 2022-10-24 21:10:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5733
Comment 4 EWS 2022-10-25 16:51:59 PDT 
Committed 255993@main (1d29cf3005f2): <https://commits.webkit.org/255993@main>

Reviewed commits have been landed. Closing PR #5733 and removing active labels.