Bug 246905 - AX: AccessibilityNodeObject::ariaLabeledByText appends to a Vector that it never uses
Summary: AX: AccessibilityNodeObject::ariaLabeledByText appends to a Vector that it ne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-22 12:19 PDT by Tyler Wilcock
Modified: 2022-10-22 20:47 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2022-10-22 12:21 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-10-22 12:19:56 PDT 
In this commit:

https://github.com/WebKit/WebKit/commit/f8283a7eece23958929380c652cebb7e7d302244 (Removed unused textElements member from AccessibilityText structure)

We stopped using the local `axElements` Vector in AccessibilityNodeObject::ariaLabeledByText, but still build it for no reason.
Comment 1 Radar WebKit Bug Importer 2022-10-22 12:20:08 PDT 
<rdar://problem/101462816>
Comment 2 Tyler Wilcock 2022-10-22 12:21:38 PDT 
Created attachment 463169 [details]
Patch
Comment 3 EWS 2022-10-22 20:47:56 PDT 
Committed 255890@main (e081fcf0fbd4): <https://commits.webkit.org/255890@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463169 [details].