Bug 246888 - SVG text in RTL mixes characters
Summary: SVG text in RTL mixes characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2022-10-21 15:42 PDT by Ahmad Saleem
Modified: 2023-03-10 05:02 PST (History)
5 users (show)

See Also:


Attachments
Patch Applied (219.58 KB, image/png)
2023-03-06 12:33 PST, Ahmad Saleem
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-10-21 15:42:43 PDT
Hi Team,

I tried to search for this bug but couldn't find to do Blink commit merge, hence, I am creating this as new:

Test Case failing in Safari 16 and STP 155 - https://jsfiddle.net/L3fmwvre/show

Chromium / Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=167777

Where to merge - https://github.com/WebKit/WebKit/blob/ce0ee18aa01d4d38b4dc7e9535ea61e24234c6cb/Source/WebCore/rendering/svg/SVGRootInlineBox.cpp#L262

_____

Just wanted to create a bug for it.

Thanks!
Comment 1 Karl Dubost 2022-10-24 18:32:23 PDT
fwiw I tempted to apply the same code change to WebKit. 
and the SVG doesn't display anymore. So there's probably more to it.
Comment 2 Ahmad Saleem 2022-10-25 00:43:51 PDT
(In reply to Karl Dubost from comment #1)
> fwiw I tempted to apply the same code change to WebKit. 
> and the SVG doesn't display anymore. So there's probably more to it.

Yes - it requires prerequisite, I noticed in my PR as well.

https://github.com/WebKit/WebKit/pull/5656#issuecomment-1288157540
Comment 3 Radar WebKit Bug Importer 2022-10-28 15:43:22 PDT
<rdar://problem/101695671>
Comment 4 Ahmad Saleem 2023-03-06 12:33:00 PST
Created attachment 465321 [details]
Patch Applied

It does not fix completely but make it less broken as can be seen from attached picture. Thanks!
Comment 5 EWS 2023-03-10 05:02:51 PST
Committed 261495@main (46f0f6ec886e): <https://commits.webkit.org/261495@main>

Reviewed commits have been landed. Closing PR #11194 and removing active labels.