Bug 246862 - Decide how to handle -Wrestrict warning in SFrameUtils.cpp
Summary: Decide how to handle -Wrestrict warning in SFrameUtils.cpp
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-21 09:52 PDT by Michael Catanzaro
Modified: 2022-10-28 09:53 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-10-21 09:52:42 PDT 
GCC is complaining about a memcpy in SFrameUtils.cpp:

SFrameUtils.cpp:139:16: warning: ‘void* memcpy(void*, const void*, size_t)’ accessing 18446744073709551614 bytes at offsets 0 and 0 overlaps 9223372036854775805 bytes at offset -9223372036854775807 [-Wrestrict]

Note that 18446744073709551614 is 2^64 - 2, so GCC is complaining that it thinks spsPpsLength can overflow, which would probably be real bad. For now I'll suppress it, but seemed worth reporting a bug to look into this closer.
Comment 1 Radar WebKit Bug Importer 2022-10-28 09:53:19 PDT 
<rdar://problem/101682237>