Bug 246816 - [GTK] [2.38.1] Non-unified builds broken
Summary: [GTK] [2.38.1] Non-unified builds broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-20 10:15 PDT by Alberto Garcia
Modified: 2022-10-24 04:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2022-10-20 10:15:00 PDT 
I had this while building for i386:

[1/8330] cd /tmp/webkit2gtk-2.38.1 && /usr/bin/cmake -E env CC=/usr/bin/cc /usr/bin/g-ir-scanner --quiet --warn-all --warn-error --no-libtool --output=/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore-4.0.gir --library=javascriptcoregtk-4.0 --library-path=/tmp/webkit2gtk-2.38.1/build-soup2/lib --namespace=JavaScriptCore --nsversion=4.0 --c-include=jsc/jsc.h --identifier-prefix=JSC --symbol-prefix=jsc --pkg-export=javascriptcoregtk-4.0 -DBUILDING_JavaScriptCore -DJSC_COMPILATION -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DPAS_BMALLOC=1 -DBUILDING_GTK__=1 -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -DJSC_GLIB_API_ENABLED -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DSTATICALLY_LINKED_WITH_WTF -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore/Headers --sources-top-dirs=/tmp/webkit2gtk-2.38.1 --include=GObject-2.0 --pkg=gobject-2.0 -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore/Headers -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore/PrivateHeaders -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCoreGLib/Headers -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCoreGLib/DerivedSources /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCAutocleanups.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCClass.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCContext.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCDefines.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCException.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCOptions.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCValue.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCVirtualMachine.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCWeakValue.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/jsc.h /tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCoreGLib/DerivedSources/jsc/JSCVersion.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSAPIWrapperGlobalObject.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSAPIWrapperObjectGLib.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCCallbackFunction.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCClass.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCContext.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCException.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCOptions.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCValue.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCVersion.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCVirtualMachine.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCWeakValue.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCWrapperMap.cpp
FAILED: JavaScriptCore-4.0.gir /tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore-4.0.gir
cd /tmp/webkit2gtk-2.38.1 && /usr/bin/cmake -E env CC=/usr/bin/cc /usr/bin/g-ir-scanner --quiet --warn-all --warn-error --no-libtool --output=/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore-4.0.gir --library=javascriptcoregtk-4.0 --library-path=/tmp/webkit2gtk-2.38.1/build-soup2/lib --namespace=JavaScriptCore --nsversion=4.0 --c-include=jsc/jsc.h --identifier-prefix=JSC --symbol-prefix=jsc --pkg-export=javascriptcoregtk-4.0 -DBUILDING_JavaScriptCore -DJSC_COMPILATION -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DPAS_BMALLOC=1 -DBUILDING_GTK__=1 -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -DJSC_GLIB_API_ENABLED -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DSTATICALLY_LINKED_WITH_WTF -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore/Headers --sources-top-dirs=/tmp/webkit2gtk-2.38.1 --include=GObject-2.0 --pkg=gobject-2.0 -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore/Headers -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCore/PrivateHeaders -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCoreGLib/Headers -I/tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCoreGLib/DerivedSources /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCAutocleanups.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCClass.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCContext.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCDefines.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCException.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCOptions.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCValue.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCVirtualMachine.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCWeakValue.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/jsc.h /tmp/webkit2gtk-2.38.1/build-soup2/JavaScriptCoreGLib/DerivedSources/jsc/JSCVersion.h /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSAPIWrapperGlobalObject.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSAPIWrapperObjectGLib.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCCallbackFunction.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCClass.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCContext.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCException.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCOptions.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCValue.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCVersion.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCVirtualMachine.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCWeakValue.cpp /tmp/webkit2gtk-2.38.1/Source/JavaScriptCore/API/glib/JSCWrapperMap.cpp
/usr/bin/ld: /tmp/webkit2gtk-2.38.1/build-soup2/lib/libjavascriptcoregtk-4.0.so: undefined reference to `JSC::ExecutableBase::implementationVisibility() const'
collect2: error: ld returned 1 exit status
linking of temporary binary failed: Command '['/usr/bin/cc', '-o', '/tmp/webkit2gtk-2.38.1/tmp-introspectnljrxjc5/JavaScriptCore-4.0', '/tmp/webkit2gtk-2.38.1/tmp-introspectnljrxjc5/JavaScriptCore-4.0.o', '-L.', '-Wl,-rpath,.', '-Wl,--no-as-needed', '-L/tmp/webkit2gtk-2.38.1/build-soup2/lib', '-Wl,-rpath,/tmp/webkit2gtk-2.38.1/build-soup2/lib', '-ljavascriptcoregtk-4.0', '-lgio-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lgobject-2.0', '-lglib-2.0']' returned non-zero exit status 1.
ninja: build stopped: subcommand failed.
Comment 1 Alberto Garcia 2022-10-21 06:28:37 PDT 
This fixes the problem for me:

--- webkitgtk.orig/Source/JavaScriptCore/interpreter/StackVisitor.cpp
+++ webkitgtk/Source/JavaScriptCore/interpreter/StackVisitor.cpp
@@ -28,6 +28,7 @@
 
 #include "ClonedArguments.h"
 #include "DebuggerPrimitives.h"
+#include "ExecutableBaseInlines.h"
 #include "InlineCallFrame.h"
 #include "JSCInlines.h"
 #include "RegisterAtOffsetList.h"
Comment 2 Carlos Garcia Campos 2022-10-24 01:11:31 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5700
Comment 3 EWS 2022-10-24 04:32:45 PDT 
Committed 255910@main (c5856430df80): <https://commits.webkit.org/255910@main>

Reviewed commits have been landed. Closing PR #5700 and removing active labels.