Bug 246735 - Don't unnecessarily tear down top layer renderers in RenderTreeUpdater
Summary: Don't unnecessarily tear down top layer renderers in RenderTreeUpdater
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-18 23:10 PDT by Tim Nguyen (:ntim)
Modified: 2022-10-19 08:15 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-10-18 23:10:07 PDT 
The only reason the element.isInTopLayer() check added by https://commits.webkit.org/246767@main is there is because entering top layer forces `display: contents` style to `display: block`. This  check is now redundant with https://commits.webkit.org/255527@main, since it is fixing the same issue more globally.

Test: fast/css/top-layer-display-contents-crash.html
Comment 1 Radar WebKit Bug Importer 2022-10-18 23:11:09 PDT 
<rdar://problem/101324926>
Comment 2 Tim Nguyen (:ntim) 2022-10-18 23:12:53 PDT 
Pull Request: https://github.com/WebKit/WebKit/pull/5529
Comment 3 EWS 2022-10-19 08:15:20 PDT 
Committed 255733@main (394f41a9f855): <https://commits.webkit.org/255733@main>

Reviewed commits have been landed. Closing PR #5529 and removing active labels.