246623 – browser.commands: Empty browser action reference causes conflicts

Bug 246623 - browser.commands: Empty browser action reference causes conflicts

Summary: browser.commands: Empty browser action reference causes conflicts

Status:	RESOLVED CONFIGURATION CHANGED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit Extensions (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-10-17 05:12 PDT by Carlos J.
Modified:	2022-10-18 06:23 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Carlos J. 2022-10-17 05:12:36 PDT

To provide users the ability for a keyboard shortcut to open extensions, you can define this in manifest: ``` "commands": { "_execute_browser_action": { "description": "Open extension popup" } }, ``` This doesn't set a keyboard shortcut yet allows the user to assign one. However, in iOS safari, when two extensions offer this functionality, the browser warns about it. See screenshot.

Sample extension can be found here:
https://github.com/carlosjeurissen/webext-tech-demo-extensions/tree/main/issues/safari-9633205-duplicate-empty-command-conflict

Comment 1 Carlos J. 2022-10-17 05:12:59 PDT

Previously reported as:
https://feedbackassistant.apple.com/feedback/9633205
https://developer.apple.com/forums/thread/690181

Comment 2 Alexey Proskuryakov 2022-10-17 10:20:07 PDT

This was fixed in Safari (not in WebKit) in iOS 16. Please reopen if this still reproduces for you.

rdar://83232949

Comment 3 Carlos J. 2022-10-18 06:23:53 PDT

Thanks! Good to know!