Bug 246561 - [WGSL] Prefix AST files to avoid name clashes
Summary: [WGSL] Prefix AST files to avoid name clashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks: 246558
  Show dependency tree / graph
 
Reported: 2022-10-14 21:33 PDT by Dan Glastonbury
Modified: 2022-10-17 00:17 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-10-14 21:33:13 PDT 
WebKit projects are built in Xcode using header maps, so each header file needs a unique name. WebGPU project has two headers named `ShaderModule.h`.

Since paths aren't used to disambiguate headers, I propose prefixing all WGSL AST node headers with `AST` and removing the nested directory structure.
Comment 1 Radar WebKit Bug Importer 2022-10-14 21:33:52 PDT 
<rdar://problem/101198489>
Comment 2 Dan Glastonbury 2022-10-15 22:53:46 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5426
Comment 3 EWS 2022-10-17 00:17:09 PDT 
Committed 255614@main (2b6ef0c64240): <https://commits.webkit.org/255614@main>

Reviewed commits have been landed. Closing PR #5426 and removing active labels.