Bug 246537 - REGRESSION (255506@main-255532@main): [Win] fast/block/positioning/border-change-relayout-test.html is consistently crashing
Summary: REGRESSION (255506@main-255532@main): [Win] fast/block/positioning/border-cha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-14 14:26 PDT by Ryan Haddad
Modified: 2022-11-05 19:54 PDT (History)
16 users (show)

See Also:

Attachments
crash log (154.92 KB, text/plain)
2022-10-14 14:26 PDT, Ryan Haddad 		no flags Details
Patch (5.08 KB, patch)
2022-11-01 11:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2022-11-01 18:58 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2022-11-02 20:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.20 KB, patch)
2022-11-05 09:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.24 KB, patch)
2022-11-05 12:53 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (1.25 KB, patch)
2022-11-05 19:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-10-14 14:26:26 PDT 
Created attachment 462994 [details]
crash log

fast/block/positioning/border-change-relayout-test.html is consistently crashing on Windows

FAULTING_IP: 
WebKit!WebCore::RenderStyle::operator=+22 [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\rendering\style\RenderStyle.cpp @ 145]

    Frame[00]  Triage Symbol: [WebKit!WebCore::RenderStyle::operator=+0x22]
    Frame[01]  Triage Symbol: [WebKit!WebCore::Layout::Box::updateStyle+0x19]
    Frame[02]  Triage Symbol: [WebKit!WebCore::LayoutIntegration::BoxTree::updateStyle+0xef]
    Frame[03]  Triage Symbol: [WebKit!WebCore::LayoutIntegration::LineLayout::updateStyle+0x5a]
    Frame[04]  Triage Symbol: [WebKit!WebCore::RenderBox::styleDidChange+0x987]
    Frame[05]  Triage Symbol: [WebKit!WebCore::RenderBlockFlow::styleDidChange+0x1e]
    Frame[06]  Triage Symbol: [WebKit!WebCore::RenderElement::setStyle+0x228]
    Frame[07]  Triage Symbol: [WebKit!WebCore::RenderTreeUpdater::updateElementRenderer+0x2b4]
    Frame[08]  Triage Symbol: [WebKit!WebCore::RenderTreeUpdater::updateRenderTree+0x5c5]
    Frame[09]  Triage Symbol: [WebKit!WebCore::RenderTreeUpdater::commit+0x88]
    Frame[0a]  Triage Symbol: [WebKit!WebCore::Document::updateRenderTree+0x78]
    Frame[0b]  Triage Symbol: [WebKit!WebCore::Document::resolveStyle+0x482]
    Frame[0c]  Triage Symbol: [WebKit!WebView::notifyPreferencesChanged+0x11f5]
    Frame[0d]  Triage Symbol: [WebKit!WebView::onNotify+0x88]
    Frame[0e]  Triage Symbol: [WebKit!WebNotificationCenter::postNotificationInternal+0xff]
    Frame[0f]  Triage Symbol: [WebKit!WebNotificationCenter::postNotificationName+0x3f]
    Frame[10]  Triage Symbol: [WebKit!WebPreferences::postPreferencesChangesNotification+0x69]
    Frame[11]  Triage Symbol: [WebKit!WebPreferences::stopBatchingUpdates+0x32]
    Frame[12]  Triage Symbol: [DumpRenderTreeLib!resetWebViewToConsistentStateBeforeTesting+0x2f3]
    Frame[13]  Triage Symbol: [DumpRenderTreeLib!runTest+0xc19]
    Frame[14]  Triage Symbol: [DumpRenderTreeLib!main+0x53f]
    Frame[15]  Triage Symbol: [DumpRenderTree!main+0x81d]
    Frame[16]  Triage Symbol: [DumpRenderTree!__scrt_common_main_seh+0x10c]
    Frame[17]  Triage Symbol: [KERNEL32!BaseThreadInitThunk+0x14]
    Frame[18]  Triage Symbol: [ntdll!RtlUserThreadStart+0x21]

https://results.webkit.org/?suite=layout-tests&test=fast%2Fblock%2Fpositioning%2Fborder-change-relayout-test.html&platform=win
Comment 1 Ryan Haddad 2022-10-14 15:00:46 PDT 
Skipped test in https://commits.webkit.org/255558@main to speed up EWS
Comment 2 Radar WebKit Bug Importer 2022-10-14 15:00:54 PDT 
<rdar://problem/101188134>
Comment 3 zalan 2022-11-01 11:01:14 PDT 
Created attachment 463350 [details]
Patch
Comment 4 zalan 2022-11-01 18:58:59 PDT 
Created attachment 463357 [details]
Patch
Comment 5 zalan 2022-11-02 20:27:06 PDT 
Created attachment 463375 [details]
Patch
Comment 6 zalan 2022-11-05 09:21:52 PDT 
Created attachment 463427 [details]
Patch
Comment 7 zalan 2022-11-05 12:53:50 PDT 
Created attachment 463429 [details]
Patch
Comment 8 Darin Adler 2022-11-05 12:58:54 PDT 
Comment on attachment 463429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463429&action=review

> COMMIT_MESSAGE:5
> +Unreviewed test gardening.

Doesn’t look unreviewed to me.
Comment 9 Darin Adler 2022-11-05 12:58:56 PDT 
Comment on attachment 463429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463429&action=review

> COMMIT_MESSAGE:5
> +Unreviewed test gardening.

Doesn’t look unreviewed to me.
Comment 10 zalan 2022-11-05 19:50:48 PDT 
Created attachment 463433 [details]
[fast-cq]Patch
Comment 11 zalan 2022-11-05 19:53:19 PDT 
(In reply to Darin Adler from comment #9)
> Comment on attachment 463429 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463429&action=review
> 
> > COMMIT_MESSAGE:5
> > +Unreviewed test gardening.
> 
> Doesn’t look unreviewed to me.
:) Didn't think anyone would look (especially here on good, old bugzilla)!
Comment 12 EWS 2022-11-05 19:54:21 PDT 
Committed 256371@main (f148d5c81701): <https://commits.webkit.org/256371@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463433 [details].