Bug 246481 - Safari crashes on https://knowyourmeme.com/memes/oh-the-huge-manatee
Summary: Safari crashes on https://knowyourmeme.com/memes/oh-the-huge-manatee
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-13 16:14 PDT by zalan
Modified: 2022-10-14 06:16 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.59 KB, patch)
2022-10-13 16:26 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq]Patch (3.58 KB, patch)
2022-10-13 21:02 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-10-13 16:14:37 PDT
<rdar://100914598>
Comment 1 zalan 2022-10-13 16:26:02 PDT
Created attachment 462971 [details]
Patch
Comment 2 Alexey Proskuryakov 2022-10-13 17:16:24 PDT
Comment on attachment 462971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462971&action=review

I don't have anything of substance to say, but I had comments about ChangeLog.

> COMMIT_MESSAGE:2
> +Safari crashes on 
> +https://knowyourmeme.com/memes/oh-the-huge-manatee

This should be one line.

> COMMIT_MESSAGE:8
> +This patch enables style update on the layout boxes when the renderer is floating/out-of-flow. It ensures that the layout box and the associated render stay in sync. (out of sync style could lead to an unexpected state where IFC integration layer (incorrectly) assumes that the renderer tree has certain properties (e.g. layer)).

This should probably be many lines.
Comment 3 zalan 2022-10-13 21:02:40 PDT
Created attachment 462975 [details]
[fast-cq]Patch
Comment 4 zalan 2022-10-13 21:06:50 PDT
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 462971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462971&action=review
> 
> I don't have anything of substance to say, but I had comments about
> ChangeLog.
> 
> > COMMIT_MESSAGE:2
> > +Safari crashes on 
> > +https://knowyourmeme.com/memes/oh-the-huge-manatee
> 
> This should be one line.
> 
> > COMMIT_MESSAGE:8
> > +This patch enables style update on the layout boxes when the renderer is floating/out-of-flow. It ensures that the layout box and the associated render stay in sync. (out of sync style could lead to an unexpected state where IFC integration layer (incorrectly) assumes that the renderer tree has certain properties (e.g. layer)).
> 
> This should probably be many lines.
Thank you.
Comment 5 EWS 2022-10-14 06:16:29 PDT
Committed 255531@main (f9f41e5b4d58): <https://commits.webkit.org/255531@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462975 [details].