Bug 246457 - IPC::MessageSender::sendWithAsyncReply is not consistent with send failures
Summary: IPC::MessageSender::sendWithAsyncReply is not consistent with send failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 247256
  Show dependency tree / graph
 
Reported: 2022-10-13 06:49 PDT by Kimmo Kinnunen
Modified: 2022-10-31 02:01 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-10-13 06:49:48 PDT 
IPC::MessageSender::sendWithAsyncReply is not consistent with send failures

When send fails, the MessageSender code has already added a pending async reply.
Comment 1 Radar WebKit Bug Importer 2022-10-13 06:50:33 PDT 
<rdar://problem/101124692>
Comment 2 Kimmo Kinnunen 2022-10-13 07:08:02 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5329
Comment 3 EWS 2022-10-26 04:31:01 PDT 
Committed 256008@main (b43d9276ab01): <https://commits.webkit.org/256008@main>

Reviewed commits have been landed. Closing PR #5329 and removing active labels.
Comment 4 Alex Christensen 2022-10-29 13:37:51 PDT 
This broke these API tests:
TestWebKitAPI.IPCTestingAPI.CanInterceptFindString
TestWebKitAPI.IPCTestingAPI.CanInterceptHasStorageAccess
Comment 5 Alex Christensen 2022-10-29 18:08:57 PDT 
https://github.com/WebKit/WebKit/pull/5940 fixes the test, though I'm not sure how the fuzzer will handle the interception of messages with replies now.