Bug 246450 - Tear down child renderers when removing display: contents
Summary: Tear down child renderers when removing display: contents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-13 03:05 PDT by Rob Buis
Modified: 2022-10-25 09:53 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2022-10-13 03:07 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.49 KB, patch)
2022-10-13 04:33 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.51 KB, patch)
2022-10-14 01:47 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-10-13 03:05:47 PDT 
Detect when we transition away from display: contents when
resolving computed styles and tear down child renderers in
that case. To keep track of when to do this add a flag
to Element.
Comment 1 Rob Buis 2022-10-13 03:07:17 PDT 
Created attachment 462955 [details]
Patch
Comment 2 Rob Buis 2022-10-13 04:33:05 PDT 
Created attachment 462958 [details]
Patch
Comment 3 Rob Buis 2022-10-14 01:47:08 PDT 
Created attachment 462983 [details]
Patch
Comment 4 EWS 2022-10-14 03:49:30 PDT 
Committed 255527@main (f6f2c95eb900): <https://commits.webkit.org/255527@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462983 [details].
Comment 5 Radar WebKit Bug Importer 2022-10-14 03:50:18 PDT 
<rdar://problem/101166942>
Comment 6 EWS 2022-10-25 09:53:54 PDT 
Committed 252432.665@safari-7614-branch (c10d7be58084): <https://commits.webkit.org/252432.665@safari-7614-branch>

Reviewed commits have been landed. Closing PR #158 and removing active labels.