RESOLVED FIXED246390
StreamConnectionBuffer::Header field alignment isn't great enough 
https://bugs.webkit.org/show_bug.cgi?id=246390
Summary StreamConnectionBuffer::Header field alignment isn't great enough
Cameron McCormack (:heycam)
Reported 2022-10-11 21:28:09 PDT
StreamConnectionBuffer::Header uses alignas(sizeof(uint64_t[2])) on the second field to place it in a different CPU cache line, but that that's alignas(16). We should be using alignas(64) on x86_64 and alignas(128) on ARM64.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-10-11 21:28:22 PDT
<rdar://problem/101063947>
Cameron McCormack (:heycam)
Comment 2 2022-10-11 21:40:11 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5277
EWS
Comment 3 2022-10-12 21:47:36 PDT
Committed 255469@main (b9d35939c4a2): <https://commits.webkit.org/255469@main> Reviewed commits have been landed. Closing PR #5277 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.