Bug 246390 - StreamConnectionBuffer::Header field alignment isn't great enough
Summary: StreamConnectionBuffer::Header field alignment isn't great enough
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-11 21:28 PDT by Cameron McCormack (:heycam)
Modified: 2022-10-12 21:47 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-10-11 21:28:09 PDT 
StreamConnectionBuffer::Header uses alignas(sizeof(uint64_t[2])) on the second field to place it in a different CPU cache line, but that that's alignas(16). We should be using alignas(64) on x86_64 and alignas(128) on ARM64.
Comment 1 Radar WebKit Bug Importer 2022-10-11 21:28:22 PDT 
<rdar://problem/101063947>
Comment 2 Cameron McCormack (:heycam) 2022-10-11 21:40:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5277
Comment 3 EWS 2022-10-12 21:47:36 PDT 
Committed 255469@main (b9d35939c4a2): <https://commits.webkit.org/255469@main>

Reviewed commits have been landed. Closing PR #5277 and removing active labels.