Bug 246385 - `git webkit pr` gets confused if a commit belongs multiple branches
Summary: `git webkit pr` gets confused if a commit belongs multiple branches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-10-11 20:19 PDT by Matt Woodrow
Modified: 2022-10-18 12:02 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-10-11 20:19:35 PDT 
Trying to create a PR for a checked-out branch, which also has a dependent branch, fails.

It looks like the commit is associated with multiple branches, and prioritize_branches picks the first alphabetically.

I think it should prioritise the checked out branch, and the comment there says that it does.
Comment 1 Matt Woodrow 2022-10-11 20:21:16 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5275
Comment 2 EWS 2022-10-13 18:16:18 PDT 
Committed 255516@main (df651783f47d): <https://commits.webkit.org/255516@main>

Reviewed commits have been landed. Closing PR #5275 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-13 18:17:21 PDT 
<rdar://problem/101153360>
Comment 4 EWS 2022-10-18 12:02:01 PDT 
Committed 252432.590@safari-7614-branch (14c37a4b8903): <https://commits.webkit.org/252432.590@safari-7614-branch>

Reviewed commits have been landed. Closing PR #141 and removing active labels.