Bug 246319 - encode Markable values without a separate isEmpty boolean
Summary: encode Markable values without a separate isEmpty boolean
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks: 246322
  Show dependency tree / graph
 
Reported: 2022-10-10 21:53 PDT by Cameron McCormack (:heycam)
Modified: 2022-10-11 14:31 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-10-10 21:53:54 PDT 
We currently encode Markable values by writing a bool first representing whether the value is the special empty value.  We should make use of the fact that the types used in Markable are designed to represent an "is empty" state without additional storage.
Comment 1 Radar WebKit Bug Importer 2022-10-10 21:54:14 PDT 
<rdar://problem/101014331>
Comment 2 Cameron McCormack (:heycam) 2022-10-10 22:40:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5227
Comment 3 Cameron McCormack (:heycam) 2022-10-11 14:31:42 PDT 
Decided against doing this.