Bug 246235 - [WASM-Function-References] Change call_ref to take a type index
Summary: [WASM-Function-References] Change call_ref to take a type index
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247393
  Show dependency tree / graph
 
Reported: 2022-10-07 14:37 PDT by Asumu Takikawa
Modified: 2022-11-03 12:32 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2022-10-07 14:37:53 PDT 
The typed function references spec recently made a change to the format of `call_ref`: https://github.com/WebAssembly/function-references/pull/76

The instruction now takes a type index as a fixed parameter.

e.g., `(call_ref 0 (i32.const 42) (ref.func 0))` instead of `(call_ref (i32.const 42) (ref.func 0))` before.

(This also applies to `return_call_ref`)
Comment 1 Radar WebKit Bug Importer 2022-10-14 14:38:39 PDT 
<rdar://problem/101187388>
Comment 2 Asumu Takikawa 2022-11-01 11:21:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/6002
Comment 3 EWS 2022-11-03 12:32:45 PDT 
Committed 256285@main (e8dd2e444f29): <https://commits.webkit.org/256285@main>

Reviewed commits have been landed. Closing PR #6002 and removing active labels.